This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Updating to the 7.7.0 upstream version #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ibuziuk PR check [build 1988] failed.Depending on failure reason, the artifacts or deployment may not be present. |
|
[test] |
@ibuziuk RH-Che [build 1989] has been successfully deployed and tested.deployment: http://rhche-prcheck-1722.devtools-dev.ext.devshift.net |
@ibuziuk RH-Che [build 1990] has been successfully deployed and tested.deployment: http://rhche-prcheck-1722.devtools-dev.ext.devshift.net |
mshaposhnik
approved these changes
Dec 4, 2019
amisevsk
approved these changes
Dec 4, 2019
@amisevsk yeah, the last commit is about adjusting rh-che to those changes - eclipse-che/che#15040 cc: @metlos |
|
ASP .NET Core Web Application - LS not working, installation of Cake succeeds but building application fails with Java with Spring Boot and MongoDB not able to start Log
Java with Spring Boot and MySQL - can not run project Log
NodeJS - can not execute tasks successfully Log
Python Django - preview not working correctly Logs
PHP Symfony - can not install dependencies Logs
Error highlighting is not working in some stacks, but I don't think it is major issue. Sum up: All workspaces are able to start. If you consinder running tasks as minor issue, I'm OK with releasing. edit by @amisevsk: format logs as code blocks for better readability |
skabashnyuk
approved these changes
Dec 4, 2019
6 tasks
|
We'll reuse this PR for updating to 7.6.0, since it includes a bunch of fixes for 7.5.1 that will still apply. |
amisevsk
changed the title
|
As of yet, there appear to be no changes needed in the dashboard. |
@ibuziuk PR check [build 2031] failed.Depending on failure reason, the artifacts or deployment may not be present. |
@ibuziuk PR check [build 2032] failed.Depending on failure reason, the artifacts or deployment may not be present. |
|
Tests failed because the source code in upstream changed. I'll take a look today. |
@ibuziuk PR check [build 2033] failed.Depending on failure reason, the artifacts or deployment may not be present. |
|
@Katka92 For some reason deployment of devfile and plugin registries failed |
|
Ah it's trying to deploy non-existent images like image: |-
quay.io/eclipse/che-devfile-registry:nightly
7.6.0-SNAPSHOT |
|
[test] |
|
@Katka92 do you happen why such a strange version of registry images is deployed? |
@ibuziuk PR check [build 2039] failed.Depending on failure reason, the artifacts or deployment may not be present. |
ibuziuk
force-pushed
the
update_7.5.1
branch
from
7e22d8a
to
580836e
Compare
@ibuziuk PR check [build 2043] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Closed
@ibuziuk PR check [build 2112] failed.Depending on failure reason, the artifacts or deployment may not be present. |
|
Those failures seem like test issues. I'll take a look today. cc @ibuziuk |
@ibuziuk RH-Che [build 2113] has been successfully deployed and tested.deployment: http://rhche-prcheck-1722.devtools-dev.ext.devshift.net |
19 tasks
@ibuziuk PR check [build 2121] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Pull upstream change 1c5c92147f - disable autosave on devfile editor Pull upstream change 2181ed1340 - fix dashboard build Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Changes upstream mean that the create-workspace controller no longer hosts devfile selection. Changes required to apply ephemeral mode by default are instead moved to the ready-to-go-stacks controller. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Commit 51bb0bb13f in upstream causes builds to fail on any webpack error. To work around a typescript issue, commit 2181ed1340 adds 'index.d.ts' to the dashboard base directory. Since this is not included in the packaged maven artifact, this commit adds the same file to the rh-che dashboard directory and updates the build to copy it along with the rest of the sources. Should be undone when typescript is updated >3.5 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Upstream commit 32515517bf removes che-ide-fetcher.service.ts and the cheBranding functions it depends on. This causes a webpack error on build and makes the dashboard unbuildable. Until a solution is found, this commit comments out che-ide-fetcher.service.ts Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk PR check [build 2122] failed.Depending on failure reason, the artifacts or deployment may not be present. |
… (should be re-enabled after 7.7.0 update) Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk RH-Che [build 2123] has been successfully deployed and tested.deployment: http://rhche-prcheck-1722.devtools-dev.ext.devshift.net |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating to the 7.5.1 upstream version
What issues does this PR fix or reference?
eclipse-che/che#15329
How have you tested this PR?
PR check CI